[Differential] [Request, 951 lines] D2951: Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D

kossebau (Friedrich W. H. Kossebau) noreply at phabricator.kde.org
Wed Oct 5 23:36:02 UTC 2016


kossebau created this revision.
kossebau added a reviewer: Marble.

REVISION SUMMARY
  - enforces constness some more (see issue spotted with GeoDataTrack::extendedData())
  - delivers inline-ness of the access methods
  - code should be more familiar to Qt developers

REPOSITORY
  rMARBLE Marble

BRANCH
  qtifyPimplCode

REVISION DETAIL
  https://phabricator.kde.org/D2951

AFFECTED FILES
  src/lib/marble/geodata/data/GeoDataGeometry.cpp
  src/lib/marble/geodata/data/GeoDataGeometry.h
  src/lib/marble/geodata/data/GeoDataLineString.cpp
  src/lib/marble/geodata/data/GeoDataLineString.h
  src/lib/marble/geodata/data/GeoDataModel.cpp
  src/lib/marble/geodata/data/GeoDataModel.h
  src/lib/marble/geodata/data/GeoDataMultiGeometry.cpp
  src/lib/marble/geodata/data/GeoDataMultiGeometry.h
  src/lib/marble/geodata/data/GeoDataMultiTrack.cpp
  src/lib/marble/geodata/data/GeoDataMultiTrack.h
  src/lib/marble/geodata/data/GeoDataPoint.cpp
  src/lib/marble/geodata/data/GeoDataPoint.h
  src/lib/marble/geodata/data/GeoDataPolygon.cpp
  src/lib/marble/geodata/data/GeoDataPolygon.h
  src/lib/marble/geodata/data/GeoDataTrack.cpp
  src/lib/marble/geodata/data/GeoDataTrack.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #marble
Cc: marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20161005/e0ca3b2f/attachment.html>


More information about the Marble-devel mailing list