[Marble-devel] [Differential] [Request, 356 lines] D1608: Use consistently Q_SIGNALS/Q_SLOTS (and set QT_NO_SIGNALS_SLOTS_KEYWORDS)

[kossebau (Friedrich W. H. Kossebau)]

kossebau created this revision.
kossebau added reviewers: rahn, nienhueser.

REVISION SUMMARY
  Currently there is a mix of both signals/slots and Q_SIGNALS/Q_SLOTS.
  Given Marble is also promoted as library, it seems to make sense to
  standardize on Q_SIGNALS/Q_SLOTS, and for consistency do that project-wide,
  not just for the lib API.
  Adding QT_NO_SIGNALS_SLOTS_KEYWORDS should prevent any regressions here.

TEST PLAN
  Still builds (WITH_KDE=ON & BUILD_MARBLE_EXAMPLES=ON) and marble app still
  works.

REPOSITORY
  rMARBLE Marble

BRANCH
  noSignalsSlotsKeywords

REVISION DETAIL
  https://phabricator.kde.org/D1608

AFFECTED FILES
  CMakeLists.txt
  examples/cpp/marbleQuick2/main.cpp
  examples/cpp/vehicletracking/vehicletracking.h
  src/apps/marble-kde/KdeMainWindow.h
  src/apps/marble-maps/TextToSpeechClient.h
  src/apps/marble-ui/ControlView.h
  src/lib/marble/AddLinkDialog.h
  src/lib/marble/EditPlacemarkDialog.h
  src/lib/marble/FormattedTextWidget.h
  src/lib/marble/MarbleAbstractPresenter.h
  src/lib/marble/MarbleLegendBrowser.h
  src/lib/marble/MarbleWidgetInputHandler.h
  src/lib/marble/MovieCapture.h
  src/lib/marble/MovieCaptureDialog.h
  src/lib/marble/TourCaptureDialog.h
  src/lib/marble/TreeViewDecoratorModel.h
  src/lib/marble/cloudsync/CloudRouteModel.h
  src/lib/marble/cloudsync/CloudRoutesDialog.h
  src/lib/marble/cloudsync/ConflictDialog.h
  src/lib/marble/cloudsync/MergeItem.h
  src/lib/marble/cloudsync/OwncloudSyncBackend.h
  src/lib/marble/cloudsync/RouteItemDelegate.h
  src/lib/marble/cloudsync/RouteSyncManager.h
  src/lib/marble/declarative/CloudSync.h
  src/lib/marble/declarative/MarbleQuickItem.cpp
  src/lib/marble/declarative/MarbleQuickItem.h
  src/lib/marble/declarative/Navigation.h
  src/lib/marble/declarative/Placemark.h
  src/lib/marble/declarative/SearchBackend.h
  src/lib/marble/kineticmodel.h
  src/lib/marble/osm/OsmRelationEditorDialog.h
  src/lib/marble/routing/RoutingProfileSettingsDialog.h
  src/plasmoid/worldclock.h
  src/plugins/positionprovider/geoclue/GeoCluePositionProviderPlugin.h
  src/plugins/positionprovider/geoclue/GeoCute/PositionProvider.h
  src/plugins/positionprovider/geoclue/GeoCute/Provider.h
  src/plugins/positionprovider/geoclue/GeoCute/VelocityProvider.h
  src/plugins/positionprovider/gpsd/GpsdConnection.h
  src/plugins/positionprovider/gpsd/GpsdPositionProviderPlugin.h
  src/plugins/positionprovider/gpsd/GpsdThread.h
  src/plugins/render/annotate/AnnotatePlugin.h
  src/plugins/render/annotate/EditGroundOverlayDialog.h
  src/plugins/render/annotate/EditPolygonDialog.h
  src/plugins/render/annotate/EditPolylineDialog.h
  src/plugins/render/annotate/MergingPolygonNodesAnimation.h
  src/plugins/render/annotate/MergingPolylineNodesAnimation.h
  src/plugins/render/annotate/NodeItemDelegate.h
  src/plugins/render/annotate/NodeModel.h
  src/plugins/render/atmosphere/AtmospherePlugin.h
  src/plugins/render/earthquake/EarthquakePlugin.h
  src/plugins/render/elevationprofilefloatitem/ElevationProfileContextMenu.h
  src/plugins/render/foursquare/FoursquareItem.h
  src/plugins/render/gpsinfo/GpsInfo.h
  src/plugins/render/license/License.h
  src/plugins/render/measure/MeasureConfigDialog.h
  src/plugins/render/navigation/ArrowDiscWidget.h
  src/plugins/render/opencaching/OpenCachingItem.h
  src/plugins/render/opencaching/OpenCachingPlugin.h
  src/plugins/render/opencachingcom/OpenCachingComItem.h
  src/plugins/render/opendesktop/OpenDesktopItem.h
  src/plugins/render/overviewmap/OverviewMap.h
  src/plugins/render/positionmarker/PositionMarker.h
  src/plugins/render/speedometer/Speedometer.h
  src/plugins/render/twitter/twitterPlugin.h
  src/plugins/runner/gpx/tests/TestTrack.cpp
  src/thumbnailer/thumbnailer.h
  tests/AbstractDataPluginModelTest.cpp
  tests/AbstractDataPluginTest.cpp
  tests/AbstractFloatItemTest.cpp
  tests/BillboardGraphicsItemTest.cpp
  tests/BookmarkManagerTest.cpp
  tests/FrameGraphicsItemTest.cpp
  tests/GeoDataTreeModelTest.cpp
  tests/GeoUriParserTest.cpp
  tests/GnomonicProjectionTest.cpp
  tests/LocaleTest.cpp
  tests/MapViewWidgetTest.cpp
  tests/MarbleMapTest.cpp
  tests/MarbleRunnerManagerTest.cpp
  tests/MarbleWidgetSpeedTest.cpp
  tests/MarbleWidgetTest.cpp
  tests/MercatorProjectionTest.cpp
  tests/PlacemarkPositionProviderPluginTest.cpp
  tests/PluginManagerTest.cpp
  tests/QuaternionTest.cpp
  tests/RenderPluginModelTest.cpp
  tests/RenderPluginTest.cpp
  tests/RouteRequestTest.cpp
  tests/ScreenGraphicsItemTest.cpp
  tests/StereographicProjectionTest.cpp
  tests/TestBalloonStyle.cpp
  tests/TestCamera.cpp
  tests/TestEquality.cpp
  tests/TestFeatureDetach.cpp
  tests/TestGeoData.cpp
  tests/TestGeoDataCoordinates.cpp
  tests/TestGeoDataCopy.cpp
  tests/TestGeoDataGeometry.cpp
  tests/TestGeoDataLatLonAltBox.cpp
  tests/TestGeoDataPack.cpp
  tests/TestGeoDataTrack.cpp
  tests/TestGeoDataWriter.cpp
  tests/TestGeoPainter.cpp
  tests/TestGeoSceneWriter.cpp
  tests/TestGeometryDetach.cpp
  tests/TestGroundOverlay.cpp
  tests/TestGudermannian.cpp
  tests/TestGxTimeSpan.cpp
  tests/TestGxTimeStamp.cpp
  tests/TestLatLonQuad.cpp
  tests/TestListStyle.cpp
  tests/TestModel.cpp
  tests/TestNetworkLink.cpp
  tests/TestOsmAnnotation.cpp
  tests/TestTimeSpan.cpp
  tests/TestTimeStamp.cpp
  tests/TestToCircumscribedRectangle.cpp
  tests/TestTour.cpp
  tests/TileIdTest.cpp
  tests/ViewportParamsTest.cpp
  tools/mapreproject/NasaWorldWindToOpenStreetMapConverter.h
  tools/mapreproject/OsmTileClusterRenderer.h
  tools/mapreproject/Thread.h
  tools/osm-sisyphus/region.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, rahn, nienhueser
Cc: marble-devel