[Marble-devel] [Differential] [Request, 46 lines] D1994: Fix parsing of geo coordinates in locale encoding (+ extend unit test)

kossebau (Friedrich W. H. Kossebau) noreply at phabricator.kde.org
Fri Jun 24 15:41:22 UTC 2016


kossebau created this revision.
kossebau added reviewers: Marble, nienhueser, rahn.

REVISION SUMMARY
  QString::toDouble in Qt5 no longer first tries the system locale
  
  In tests also prefer QLocale::toString over "%L1", in some Qt versionns
  (e.g. 5.6) the L might only work when QLocale::setDefault has been
  explicitely called.

TEST PLAN
  Unit tests haven been improved and are all passing.
  marble --latlon "46,09898 7,78307" in German locale works now as expected

REPOSITORY
  rMARBLE Marble

BRANCH
  fixLocaledGeoCoordParsing

REVISION DETAIL
  https://phabricator.kde.org/D1994

AFFECTED FILES
  src/lib/marble/geodata/data/GeoDataCoordinates.cpp
  tests/TestGeoDataCoordinates.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #marble, nienhueser, rahn
Cc: marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160624/914a54ac/attachment.html>


More information about the Marble-devel mailing list