[Marble-devel] [Differential] [Request, 138 lines] D2279: GeoPainter: consistent qreal-based API, separate regionFromPixmapRect()

[kossebau (Friedrich W. H. Kossebau)]

kossebau created this revision.
kossebau added reviewers: Marble, nienhueser, rahn, shentey.

REVISION SUMMARY
  GeoPainter API had a mixture of int and qreal-based methods, and internally
  was inconsistently relaying to int or qreal-based QPainter methods.
  
  Regions used for painting rects and ellipses depend on whether anti-aliasing
  is enabled or not, and can result in offsets of at least 1 pixel.
  So calculations now tries to respect that.
  
  GeoPainter::regionFromRect() was used for getting the region of pixmaps
  being rendered. Especially in non-anti-aliased mode though this does not
  match, also is there no stroke-width on painting pixmaps.
  A special GeoPainter::regionFromPixmapRect() should serve that purpose now.

REPOSITORY
  rMARBLE Marble

BRANCH
  improveGeoPainterAPI

REVISION DETAIL
  https://phabricator.kde.org/D2279

AFFECTED FILES
  src/bindings/python/sip/GeoPainter.sip
  src/lib/marble/GeoPainter.cpp
  src/lib/marble/GeoPainter.h
  src/lib/marble/routing/RoutingLayer.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #marble, nienhueser, rahn, shentey
Cc: marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160724/40f07596/attachment.html>