[Marble-devel] [Differential] [Request, 8 lines] D2138: Fix default crosshair having an offset
kossebau (Friedrich W. H. Kossebau)
noreply at phabricator.kde.org
Mon Jul 11 16:45:32 UTC 2016
kossebau created this revision.
kossebau added reviewers: Marble, rahn, nienhueser.
REVISION SUMMARY
Code assumed all images used for the crosshair have a size of 21x21.
The default image though is a PNG of a pre-rendered crosshair with a shadow,
which thus is not of that size.
That pre-rendered image, crosshairs-darkened.png, also had a size of 32x32,
while the crosshair in it had a pixel width of 1, so it's center would
not be pixel aligned with the cross lines. Image now resized to have
crosshair in the middle pixels.
TEST PLAN
Crosshair now is centered on middle, tested e.g. with 0, 0 lonlat.
REPOSITORY
rMARBLE Marble
BRANCH
fixDefaultCrossHairPosition
REVISION DETAIL
https://phabricator.kde.org/D2138
AFFECTED FILES
src/plugins/render/crosshairs/CrosshairsPlugin.cpp
src/plugins/render/crosshairs/crosshairs-darkened.png
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #marble, rahn, nienhueser
Cc: marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160711/44c9fa55/attachment.html>
More information about the Marble-devel
mailing list