[Marble-devel] [Differential] [Updated, 445 lines] D808: Dedicated bookmarks icon chooser showing standard icons
tandon (Akshat Tandon)
noreply at phabricator.kde.org
Thu Jan 14 10:00:44 UTC 2016
tandon updated this revision to Diff 1954.
tandon marked 6 inline comments as done.
tandon added a comment.
Updates
- Changed the base class in IconChooserDialog.ui to QDialog from QWidget
- Changed the layout in IconChooserDialog.ui so that the list view re-sizes correctly.
- Replaced OK and Cancel buttons with a QDialog button box.
- Used Q_UNUSED macro in place where it was required.
- endInsertRows() is now being called from inside addIcon() instead of insertRows()
REPOSITORY
rMARBLE Marble
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D808?vs=1934&id=1954
REVISION DETAIL
https://phabricator.kde.org/D808
AFFECTED FILES
src/lib/marble/CMakeLists.txt
src/lib/marble/IconChooserDialog.cpp
src/lib/marble/IconChooserDialog.h
src/lib/marble/IconChooserDialog.ui
src/lib/marble/IconChooserModel.cpp
src/lib/marble/IconChooserModel.h
src/lib/marble/PlacemarkEditHeader.cpp
src/lib/marble/libmarble.qrc
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: tandon, Marble, nienhueser
Cc: nienhueser, Marble, cmihalache, marble-devel
More information about the Marble-devel
mailing list