[Marble-devel] Review Request 126729: Bug 345919 - Bookmark icons use absolute paths in any case

[Akshat Tandon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126729/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 10:49 p.m.)


Review request for Marble.


Bugs: 345919
    http://bugs.kde.org/show_bug.cgi?id=345919


Repository: marble


Description
-------

Bug 345919 - Bookmark icons use absolute paths in any case
https://bugs.kde.org/show_bug.cgi?id=345919

Feature
A new dialog added which allows a user to select one of the standard icons for his bookmark.All the predefined icons are in qrc folder qrc:/marble/bookmarks/. Apart from this the user can also use a custom icon for the bookmark.

Usage:
Choose Add a new Bookmark/ Edit a bookmark.
Click on the button which displays the icon.
A new dialog is created using which one of the icons can be choosen.
Click on 'Custom' button if a custom icon is to be choosen.
Select the appropriate icon and click on 'OK'.
Click on 'Cancel' if you want the previous icon to remain unchanged.


Diffs
-----

  src/lib/marble/CMakeLists.txt 42fe56f 
  src/lib/marble/IconChooserDialog.h PRE-CREATION 
  src/lib/marble/IconChooserDialog.cpp PRE-CREATION 
  src/lib/marble/IconChooserDialog.ui PRE-CREATION 
  src/lib/marble/IconChooserModel.h PRE-CREATION 
  src/lib/marble/IconChooserModel.cpp PRE-CREATION 
  src/lib/marble/PlacemarkEditHeader.cpp 893d051 
  src/lib/marble/libmarble.qrc f30e887 

Diff: https://git.reviewboard.kde.org/r/126729/diff/


Testing
-------


File Attachments (updated)
----------------

Bookmark icon chooser dialog.
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/12/8d98c947-ad3c-4f44-9c13-e0517352ec21__bookmark.png


Thanks,

Akshat Tandon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160112/5b736d77/attachment.html>