[Marble-devel] Review Request 126605: Fix open game window with zero questions.

Dennis Nienhüser dennis at nienhueser.de
Sun Jan 3 09:04:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126605/#review90488
-----------------------------------------------------------


Why not implement it by altering the "enabled" property of the button? This has the advantage that the user knows the button does nothing. Like `enabled: slider.value > 0`

- Dennis Nienhüser


On Jan. 2, 2016, 3:23 p.m., Andrey Cygankov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126605/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2016, 3:23 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> GCI-2015 task: https://codein.withgoogle.com/dashboard/task-instances/5773593514344448/
> 
> 
> Diffs
> -----
> 
>   examples/cpp/marble-game/GameOptions.qml 6c6f517 
> 
> Diff: https://git.reviewboard.kde.org/r/126605/diff/
> 
> 
> Testing
> -------
> 
> Tested, it works fine.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160103/fdcfd64c/attachment.html>


More information about the Marble-devel mailing list