[Differential] [Request, 28 lines] D2408: AzimuthalProjection: Avoid duplicated globeHidesPoint calculation in iteration

kossebau (Friedrich W. H. Kossebau) noreply at phabricator.kde.org
Thu Aug 11 14:24:38 UTC 2016


kossebau created this revision.
kossebau added reviewers: Marble, rahn.

REVISION SUMMARY
  In the first recursive call there is no need to recalculate whether the
  currentCoords parameter of AzimuthalProjectionPrivate::findHorizon(...)
  is hidden by the globe, because that information is already known on the
  previous level.
  Splitting the findHorizon() method into a "interface" method and
  a "worker" method for the recursion, where the existing information
  is passed on, allows to avoid that duplicated calculation.

REPOSITORY
  rMARBLE Marble

BRANCH
  avoidDuplicatedglobeHidesPointCall

REVISION DETAIL
  https://phabricator.kde.org/D2408

AFFECTED FILES
  src/lib/marble/projections/AzimuthalProjection.cpp
  src/lib/marble/projections/AzimuthalProjection_p.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #marble, rahn
Cc: marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20160811/0ced0d96/attachment.html>


More information about the Marble-devel mailing list