[Marble-devel] Review Request 124807: Scrollable waypoint list and small elev. bugfix

Dennis Nienhüser dennis at nienhueser.de
Tue Sep 22 18:51:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124807/#review85778
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Sept. 21, 2015, 7:58 p.m., Oliver Haag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124807/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 7:58 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Scrollable waypoint list for routing and fix for invalid elevation data
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileDataSource.cpp abe3329dcbb80c824c9cb44739f8e0c8917d0449 
>   src/lib/marble/routing/RoutingWidget.ui 22ae663687e5091f8cd5034a1134774e20ca0711 
>   src/lib/marble/routing/RoutingWidget.cpp a58667f0f3ee55b7724de8032a5c2571245bc66c 
>   src/lib/marble/routing/RoutingInputWidget.cpp 00aa0e72f3a00bf50ffe0257aed1ee105d9d2b28 
> 
> Diff: https://git.reviewboard.kde.org/r/124807/diff/
> 
> 
> Testing
> -------
> 
> Some routing for bike tours. Had 0 m elevation data in the elevation profile because invalid was replaced by 0 in getElevation, although invalid data will be filtered out later. I'm not using .ui files for other projects so not sure if I messed up anything with the scrollable layout changes ;)
> 
> 
> Thanks,
> 
> Oliver Haag
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150922/891525a9/attachment.html>


More information about the Marble-devel mailing list