[Marble-devel] Review Request 125880: change QT_IMPORTS_DIR to also cover false and NOTFOUND

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125880/#review87737
-----------------------------------------------------------


+1

- Bhushan Shah


On Oct. 30, 2015, 5:01 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125880/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2015, 5:01 p.m.)
> 
> 
> Review request for Marble and Bhushan Shah.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> if(DEFINED var) only checks if the var is defined, but with certain Finders
> var can be set but NOTFOUND.
> 
> For the purposes of the if at hand we want to make sure that we have a
> *valid* QT_IMPORTS_DIR not just a set one. To that end if(var) is the
> correct instruction here as var being undefined, 0, OFF, IGNORE or NOTFOUND
> will end up as a false condition making sure that we only set
> MARBLE_QT_IMPORTS_DIR to the value of QT_IMPORTS_DIR iff it is a truthy
> value.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 063d1cae56d315d94d33e7f75089ea9e51ec6cb0 
> 
> Diff: https://git.reviewboard.kde.org/r/125880/diff/
> 
> 
> Testing
> -------
> 
> checked that if(var) in fact evaluates to false on undefined vars. I do not have a test case at hand as this is to get rid of a debian patch that never was forwarded http://anonscm.debian.org/cgit/pkg-kde/applications/marble.git/tree/debian/patches/fix_qmake_fallback.diff?id=74c0c6fb8ac8cdad09c6d7ec86f881af10e029a8
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20151030/5ce5aca6/attachment.html>