[Marble-devel] Review Request 125740: Added merging for unclosed ways in OsmRelation.

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125740/#review87277
-----------------------------------------------------------

Ship it!


Also fixes the Colosseum in Rome :-)


src/plugins/runner/osm/OsmRelation.cpp (line 117)
<https://git.reviewboard.kde.org/r/125740/#comment59948>

    Can you comment that one? I expect quite some debug spam from it.


- Dennis Nienhüser


On Oct. 21, 2015, 5:57 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125740/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:57 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Added merging for unclosed ways in OsmRelation.
> 
> Now relations that have 2+ ways are displayed more properly. Because of that there are some visual problems with items that wasn't displayed before and haven't proper visual category yet (like black roads in screenshot). Also, Moscow Kremlin somehow tries to be a one whole building and light green layer on "After" screenshot probably have wrong z-value (because it hides some other objects).
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/osm/OsmRelation.cpp b2251d7 
> 
> Diff: https://git.reviewboard.kde.org/r/125740/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/21/140f72c6-d149-47cb-a62f-3164552ef9eb__snapshot13.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/21/e5fa2f98-d6c1-4cf5-8934-5cfe433f93a2__snapshot12.png
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20151022/5aa587df/attachment.html>