[Marble-devel] Review Request 124834: Better zoom with the mouse wheel for the Openstreetmap map theme and added a new empty map theme for OSM file loading.

[Dávid Kolozsvári]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124834/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 6:31 a.m.)


Review request for Marble.


Changes
-------

Corrected the issuespointedout by Torsten Rahn and Dennis Nienhüser.


Repository: marble


Description
-------

* There is a `zoomAt()` and a `zoomBy()` method in `MarbleAbstractPresenter`, so I've created a new `void MarbleAbstractPresenter::zoomAtBy(const QPoint &pos, int zoomStep)` method to combine the functionality of both. This new method is used in `MarbleDefaultInputHandler::handleWheel()`, but only if the map theme is `Openstreetmap`.
* The new `Empty` map theme is a simple 50 line .dgml file, with just a single empty geodata layer. Calling it `Empty` is a good idea or should we use another name for it?


Diffs (updated)
-----

  data/CMakeLists.txt 714d3ac 
  data/maps/earth/empty/empty-preview.png PRE-CREATION 
  data/maps/earth/empty/empty.dgml PRE-CREATION 
  data/maps/earth/openstreetmap/openstreetmap.dgml a462504 
  src/lib/marble/MarbleAbstractPresenter.h f44418a 
  src/lib/marble/MarbleAbstractPresenter.cpp acaab22 
  src/lib/marble/MarbleInputHandler.cpp d94144e 
  src/lib/marble/MarbleMap.h 5cb3c10 
  src/lib/marble/MarbleMap.cpp abc3357 

Diff: https://git.reviewboard.kde.org/r/124834/diff/


Testing
-------

A small video demonstrating these two new features:
https://www.youtube.com/watch?v=jMorQDwr2A8


File Attachments
----------------

empty-preview.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/132190ff-11f7-45a2-b361-266f6aa752fc__empty-preview.png
empty.dgml
  https://git.reviewboard.kde.org/media/uploaded/files/2015/08/20/39c98dcb-b35f-421a-bcf9-c3f95f15cfe3__empty.dgml


Thanks,

Dávid Kolozsvári

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20151020/1f403f87/attachment.html>