[Marble-devel] Review Request 125572: define QT_NO_VERSION_TAGGING

[Antonio Larrosa Jimenez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125572/
-----------------------------------------------------------

(Updated Oct. 9, 2015, 7:20 p.m.)


Review request for Marble.


Changes
-------

test description


Repository: marble


Description
-------

Since libastro doesn't link to Qt libraries, in order to not keep
an undefined reference to qt_version_tag in libastro,
QT_NO_VERSION_TAGGING has to be defined


Diffs
-----

  src/lib/astro/astrolib_export.h a0f7735696ec34207fc0cd86ed0c7ea766bf026b 

Diff: https://git.reviewboard.kde.org/r/125572/diff/


Testing (updated)
-------

I tested the patch in https://build.opensuse.org/package/show/home:alarrosa:branches:KDE:Applications/marble
compiling digikam successfully against it at: https://build.opensuse.org/package/show/home:alarrosa:branches:KDE:Applications4/digikam
(previously when digikam linked against libastro there was an "undefined symbol: qt_version_tag" error


Thanks,

Antonio Larrosa Jimenez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20151009/46f07da9/attachment.html>