[Marble-devel] Review Request 125996: Some qBound vs. qreal fixes

Dennis Nienhüser dennis at nienhueser.de
Sun Nov 8 20:33:32 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125996/#review88168
-----------------------------------------------------------

Ship it!


Ship It!

- Dennis Nienhüser


On Nov. 8, 2015, 7:51 nachm., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125996/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 7:51 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> As needed to build where `qreal` is `float` :)
> 
> Because `GeoDataLineStyle::setPhysicalWidth(float)` takes a `float`, I changed the type in `OsmWay.cpp` to always `float`, other than in the other fixes.
> 
> 
> Diffs
> -----
> 
>   examples/cpp/marbleQuick2/main.cpp a28e5ce 
>   src/lib/marble/declarative/MarbleQuickItem.cpp f231879 
>   src/plugins/runner/osm/OsmWay.cpp 70724b7 
> 
> Diff: https://git.reviewboard.kde.org/r/125996/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20151108/f1d3df4a/attachment.html>


More information about the Marble-devel mailing list