[Marble-devel] Review Request 123866: Add KmlLabelTagWriter

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123866/#review80707
-----------------------------------------------------------


Looks fine except some minor stuff noted below. Can you add a unit test as well? It's not much work here, all you need to do is to extend one of the .kml files in tests/data/ by a couple of label styles. And make sure the unit tests still pass of course :)
The unit test which uses the files in tests/data is tests/TestGeoDataWriter.cpp


src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp (line 37)
<https://git.reviewboard.kde.org/r/123866/#comment55333>

    KmlColorStyleTagWriter takes care of writing colorMode already, so this is not needed here. If the value is 'normal', it will not be written to the KML file. This is expected behavior since 'normal' is the default value.



src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp (line 49)
<https://git.reviewboard.kde.org/r/123866/#comment55337>

    QColor(0,0,0,255) => QColor( Qt::white )



src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp (line 50)
<https://git.reviewboard.kde.org/r/123866/#comment55335>

    0 => GeoDataColorStyle::Normal



src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp (line 50)
<https://git.reviewboard.kde.org/r/123866/#comment55336>

    0 => GeoDataColorStyle::Normal



src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp (line 51)
<https://git.reviewboard.kde.org/r/123866/#comment55334>

    0 => GeoDataLabelStyle::Corner


- Dennis Nienhüser


On May 20, 2015, 10:20 p.m., Constantin Mihalache wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123866/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 10:20 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Implemented the KmlLabelTagWriter which is useful for writing styles for TextAnnotations.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/CMakeLists.txt fe22e24 
>   src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.h PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlLabelStyleTagWriter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123866/diff/
> 
> 
> Testing
> -------
> 
> It works as expected.
> 
> 
> Thanks,
> 
> Constantin Mihalache
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150521/7084c8aa/attachment.html>