[Marble-devel] Review Request 123406: Adds the possibility to change the Map Theme and Projection from within the Tour Widget playlist ( adds the GeoDataMapChange element )

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123406/#review80148
-----------------------------------------------------------



src/lib/marble/MapChangeEditDialog.h (line 37)
<https://git.reviewboard.kde.org/r/123406/#comment54984>

    This is named like a signal ("*Changed") and thereby is also named after what happened. Instead it should be named according to what the method does (e.g. updateMapViewForCelestialBody()).


- Torsten Rahn


On Mai 2, 2015, 3:46 nachm., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123406/
> -----------------------------------------------------------
> 
> (Updated Mai 2, 2015, 3:46 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> DEPENDECY: https://git.reviewboard.kde.org/r/123594/  -- Refactoring some classes. This patch needs those classes.
> so be sure to apply 123594 patch first, then 123406.
> 
> Firstly:
> 
> - GeoDataMapChange is introduced, as a tour primitive. It adds the possibility to schedule a map theme or projection change from within the Tour Widget Playlist.
> - MapChangeEditDialog makes editing possible for the GeoDataMapChange elements. It uses the same UI from the MapViewWidget.
> - KmlMapChangeTagWriter/Handler + KmlThemeTagHandler + KmlProjectionTagHandler make import/export possible this way:
>      Example kmlFile:
>      <mx:MapChange>
>           <mx:theme>earth/citylights/citylights.dgml</mx:theme>
>           <mx:projection>Spherical</mx:projection>
>      </mx:MapChange>
>      
>      This, after parsing, represents a mapChange element that will change the current map theme to       
>      earth/citylights/citylights.dgml and projection to Spherical (Globe)
>      
> - As it can be seen above, a new xml namespace was introduced (mx), because the new element is Marble only.
> - Adds a new icon for the mapChange item. ( mapChange.png )
> 
> 
> Diffs
> -----
> 
>   data/bitmaps/map-change.png PRE-CREATION 
>   src/lib/marble/CMakeLists.txt f448f84 
>   src/lib/marble/MapChangeEditDialog.h PRE-CREATION 
>   src/lib/marble/MapChangeEditDialog.cpp PRE-CREATION 
>   src/lib/marble/MapChangeTrack.h PRE-CREATION 
>   src/lib/marble/MapChangeTrack.cpp PRE-CREATION 
>   src/lib/marble/TourItemDelegate.h d0d67d3 
>   src/lib/marble/TourItemDelegate.cpp b038a7f 
>   src/lib/marble/TourPlayback.cpp f9bf828 
>   src/lib/marble/TourWidget.h a6cb8ca 
>   src/lib/marble/TourWidget.cpp b9fab0e 
>   src/lib/marble/geodata/CMakeLists.txt fe22e24 
>   src/lib/marble/geodata/data/GeoDataMapChange.h PRE-CREATION 
>   src/lib/marble/geodata/data/GeoDataMapChange.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h f2c062c 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp ea53d43 
>   src/lib/marble/geodata/handlers/kml/KmlMapChangeTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlMapChangeTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlProjectionTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlProjectionTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlThemeTagHandler.h PRE-CREATION 
>   src/lib/marble/geodata/handlers/kml/KmlThemeTagHandler.cpp PRE-CREATION 
>   src/lib/marble/geodata/parser/GeoDataParser.cpp 588b086 
>   src/lib/marble/geodata/parser/GeoDataTypes.h 45d81d3 
>   src/lib/marble/geodata/parser/GeoDataTypes.cpp 47fde69 
>   src/lib/marble/geodata/writers/kml/KmlMapChangeTagWriter.h PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlMapChangeTagWriter.cpp PRE-CREATION 
>   src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.h d01fd7b 
>   src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp 131e3ab 
>   src/lib/marble/geodata/writers/kml/KmlTagWriter.cpp 47ca42c 
>   src/lib/marble/libmarble.qrc f30e887 
> 
> Diff: https://git.reviewboard.kde.org/r/123406/diff/
> 
> 
> Testing
> -------
> 
> I've tested the feature as much as I could and it worked. If you find any bugs, please report an issue.
> 
> 
> File Attachments
> ----------------
> 
> map-change.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/02/4283fef0-2175-4220-aae1-7b42dfb08a76__map-change.png
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150510/491e9b7f/attachment.html>