[Marble-devel] Review Request 121395: Adding AbstractProjection::boundingLinearRing()

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Tue May 5 21:17:13 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121395/
-----------------------------------------------------------

(Updated May 6, 2015, 12:17 a.m.)


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, and Torsten Rahn.


Changes
-------

So what are we going to do with this one? I did my best to fix issues Dennis' spotted.


Repository: marble


Description
-------

GCI-2014 related task: https://www.google-melange.com/gci/task/view/google/gci2014/6356744502509568

Newly added method allows to avoid zig-zag lines appearing while sampling GeoDataLatLonAltBox. Moving forward to sample a good n-side polygon.


Diffs (updated)
-----

  src/lib/marble/projections/AbstractProjection.h 719e9f8 
  src/lib/marble/projections/AbstractProjection.cpp 591adc0 
  src/plugins/render/overviewmap/OverviewMap.h 4c9ada8 
  src/plugins/render/overviewmap/OverviewMap.cpp 26affae 

Diff: https://git.reviewboard.kde.org/r/121395/diff/


Testing
-------

Visual testing, works as expected.


File Attachments
----------------

Screen Shot 2014-12-09 at 3.42.41 PM.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/6924aa58-3b28-4bab-9d3b-8adaf759afd1__Screen_Shot_2014-12-09_at_3.42.41_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150505/7b4b38a1/attachment.html>


More information about the Marble-devel mailing list