[Marble-devel] Review Request 123594: Refactoring (delegate and view proxy) classes from MapViewWidget

Marius Stanciu stanciumarius94 at gmail.com
Sat May 2 15:38:17 UTC 2015

This is an automatically generated e-mail. To reply, visit:

Review request for Marble.

Repository: marble


Separated the refactoring part of the Map Change patch posted earlier. ( to improve clarity and patch size )

This patch refactors the MapViewItemDelegate and CelestialSortFilterProxy classes from MapViewWidget.cpp to 
extend their use in the MapChangeEditDialog ( https://git.reviewboard.kde.org/r/123406/ )


  src/lib/marble/CMakeLists.txt f448f84 
  src/lib/marble/CelestialSortFilterProxyModel.h PRE-CREATION 
  src/lib/marble/CelestialSortFilterProxyModel.cpp PRE-CREATION 
  src/lib/marble/MapViewItemDelegate.h PRE-CREATION 
  src/lib/marble/MapViewItemDelegate.cpp PRE-CREATION 
  src/lib/marble/MapViewWidget.cpp 4d8f9f6 

Diff: https://git.reviewboard.kde.org/r/123594/diff/


This does no real modification to Marble. Considered compiling it succesfully to be enough of a test.


Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150502/6f29017e/attachment.html>

More information about the Marble-devel mailing list