[Marble-devel] Review Request 123182: Optimize for animation on drag, not on press

Dennis Nienhüser earthwings at gentoo.org
Mon Mar 30 14:04:07 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123182/#review78217
-----------------------------------------------------------

Ship it!


Lovely: The map doesn't look ugly anymore when clicking on it.

- Dennis Nienhüser


On March 30, 2015, 11:35 a.m., Adam Dabrowski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123182/
> -----------------------------------------------------------
> 
> (Updated March 30, 2015, 11:35 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Start optimized rendering of the map (Animation mode) only when dragging is started, not when the button is pressed. It was especially annoying with touch screens, as every touch lowered the quality of the map without necessity (practically no performance improvement).
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleInputHandler.cpp 5ffe208 
> 
> Diff: https://git.reviewboard.kde.org/r/123182/diff/
> 
> 
> Testing
> -------
> 
> With both mouse and touch screen, clicked on a map, dragged around. Have been using this code since several months now.
> 
> 
> Thanks,
> 
> Adam Dabrowski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150330/8f1a0dda/attachment.html>


More information about the Marble-devel mailing list