[Marble-devel] Review Request 123139: Fixed the bug not being able to change the GroundOverlay's texture
Dennis Nienhüser
earthwings at gentoo.org
Sat Mar 28 18:26:41 UTC 2015
Hi Dávid, Marius
thanks for your work! When you write commit messages, please always add
descriptive log messages, not just the review ID, and make sure the
second line (if there is one) is empty. See [1] and [2]. When you use
keywords like the review ID (which is good), follow the template to the
letter. I.e. use
REVIEW: 12345
instead of
REVIEW: [12345]
as the line must be understood not only by clever humans, but more
importantly by stupid scripts :)
Regards,
Dennis
[1]
https://techbase.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages
[2]
https://techbase.kde.org/Development/Git/Configuration#Commit_Template
Am 28.03.2015 18:08, schrieb Dávid Kolozsvári:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123139/ [1]
>
> THIS CHANGE HAS BEEN MARKED AS SUBMITTED.
>
> Review request for Marble.
> By Dávid Kolozsvári.
>
> _Updated March 28, 2015, 5:08 p.m._
>
> CHANGES
>
> Submitted with commit beee570a9473b27bd89cc2cb54ceec9a46369779 by
> Dávid Kolozsvári to branch master.
>
> REPOSITORY: marble
>
> DESCRIPTION
>
> The function GeoDataFeature::setIconFile( const QString &path ) should
> change the image too.
>
> TESTING
>
> Testing was done by me and works fine.
>
> DIFFS
>
> * src/lib/marble/geodata/data/GeoDataOverlay.cpp (352ef7a)
>
> View Diff [2]
>
>
>
> Links:
> ------
> [1] https://git.reviewboard.kde.org/r/123139/
> [2] https://git.reviewboard.kde.org/r/123139/diff/
>
> _______________________________________________
> Marble-devel mailing list
> Marble-devel at kde.org
> https://mail.kde.org/mailman/listinfo/marble-devel
More information about the Marble-devel
mailing list