[Marble-devel] Review Request 123122: Added 'Formatted text' description to Polyline and GroundOverlay.

[Torsten Rahn]

> On März 27, 2015, 10:02 vorm., Torsten Rahn wrote:
> > Great, but isn't this copying a lot of code? Due to the complexity of the description tab it would be better to refactor the tab into a widget which could be reused in all three places.
> 
> Constantin Mihalache wrote:
>     Sounds great. That might have crossed my mind at least once while i was copying all the code. I'll try to do what you proposed.

Cool :)


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123122/#review78105
-----------------------------------------------------------


On März 24, 2015, 6:39 nachm., Constantin Mihalache wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123122/
> -----------------------------------------------------------
> 
> (Updated März 24, 2015, 6:39 nachm.)
> 
> 
> Review request for Marble and Calin Cruceru.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I respected the structured given by EditPlacemarkDialog, which had formatted description.
> *I initially added this function to Polygons as well, but due to recent changes to EditPolygonDialog files, my patch could not be applied.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/EditPlacemarkDialog.cpp 3d0d61f 
>   src/lib/marble/EditPlacemarkDialog.ui e17bf14 
>   src/plugins/render/annotate/EditGroundOverlayDialog.h 27a1a0f 
>   src/plugins/render/annotate/EditGroundOverlayDialog.cpp df7d6d2 
>   src/plugins/render/annotate/EditGroundOverlayDialog.ui 1151b35 
>   src/plugins/render/annotate/EditPolylineDialog.h 4d383b8 
>   src/plugins/render/annotate/EditPolylineDialog.cpp a99a3e9 
>   src/plugins/render/annotate/EditPolylineDialog.ui 3421a72 
> 
> Diff: https://git.reviewboard.kde.org/r/123122/diff/
> 
> 
> Testing
> -------
> 
> It works as well for Polylines and GroundOverlays as it does for Placemarks.
> 
> 
> Thanks,
> 
> Constantin Mihalache
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150327/d17a662f/attachment.html>