[Marble-devel] Review Request 123036: Marble crashes when use placemarks from the "Edit Maps" panel and rotate globe

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123036/#review78107
-----------------------------------------------------------



src/plugins/render/annotate/AnnotatePlugin.cpp (line 1071)
<https://git.reviewboard.kde.org/r/123036/#comment53517>

    Hm, looking deeper into this I wonder why you need to check for m_focusItem here - and there are similar if clauses in the rest of the code - so is this really the best place to check for m_focusItem being defined?


- Torsten Rahn


On März 18, 2015, 6:24 nachm., hardik  beladiya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123036/
> -----------------------------------------------------------
> 
> (Updated März 18, 2015, 6:24 nachm.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Bugs: 342777
>     http://bugs.kde.org/show_bug.cgi?id=342777
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I add condition that if it has focus then after we enable remove action
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp fb49eac 
> 
> Diff: https://git.reviewboard.kde.org/r/123036/diff/
> 
> 
> Testing
> -------
> 
> Tested and does not crash because we disable the remove action if it has not focus :-)
> 
> 
> Thanks,
> 
> hardik  beladiya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150327/a4a51331/attachment.html>