[Marble-devel] Review Request 122849: Implemented the scale feature (for icons and labels) when adding placemarks via the Edit Mode

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122849/
-----------------------------------------------------------

(Updated March 25, 2015, 9:42 p.m.)


Review request for Marble.


Changes
-------

Refactored the code to a much better location and fixed the centering issues


Repository: marble


Description
-------

The feature was disabled(greyed out) and it didn't work. Now drawing the placemark keeps account of the scale member.

I have one issue though:
I didn't really know where to place a constant for a maximum icon size( limiting the user ) so I could use your opinion.


Diffs (updated)
-----

  src/lib/marble/EditPlacemarkDialog.ui e17bf14 
  src/lib/marble/PlacemarkLayout.cpp 6c0af30 
  src/lib/marble/VisiblePlacemark.cpp d57dcb0 
  src/lib/marble/geodata/data/GeoDataIconStyle.h 4afb115 
  src/lib/marble/geodata/data/GeoDataIconStyle.cpp 5385cd1 
  src/lib/marble/geodata/data/GeoDataLabelStyle.h 046f7bc 
  src/lib/marble/geodata/data/GeoDataLabelStyle.cpp 1ec0c78 

Diff: https://git.reviewboard.kde.org/r/122849/diff/


Testing
-------

works for me.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150325/0cc70944/attachment.html>