[Marble-devel] Review Request 122849: Implemented the scale feature (for icons and labels) when adding placemarks via the Edit Mode

[Torsten Rahn]

> On März 23, 2015, 10:22 nachm., Torsten Rahn wrote:
> > The patch currently scales with the top left corner of the original image size as a reference point. This leads to an apparent misplacement of the icon if you zoom it up. It also leads to a funny effect if you choose a big image (like a screenshot or big image - like 400x400) as an icon.
> > Sorry, I missed that during the review ... :-/

Instead of this behavior the image should always be centered onto the coordinate. GeoPainter::drawPixmap does this by default so I suspect that something still uses the original geometry in the code.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122849/#review77978
-----------------------------------------------------------


On März 23, 2015, 9:53 nachm., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122849/
> -----------------------------------------------------------
> 
> (Updated März 23, 2015, 9:53 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The feature was disabled(greyed out) and it didn't work. Now drawing the placemark keeps account of the scale member.
> 
> I have one issue though:
> I didn't really know where to place a constant for a maximum icon size( limiting the user ) so I could use your opinion.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/EditPlacemarkDialog.ui 2d09c6e 
>   src/lib/marble/PlacemarkLayout.cpp 6c0af30 
>   src/lib/marble/VisiblePlacemark.h 805112d 
>   src/lib/marble/VisiblePlacemark.cpp d57dcb0 
> 
> Diff: https://git.reviewboard.kde.org/r/122849/diff/
> 
> 
> Testing
> -------
> 
> works for me.
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150323/6bdd15c6/attachment.html>