[Marble-devel] Review Request 122849: Implemented the scale feature (for icons and labels) when adding placemarks via the Edit Mode

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122849/
-----------------------------------------------------------

(Updated March 23, 2015, 9:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Changes
-------

Submitted with commit 9720212b12dfee41ffe664b1d7b2f56dfe89aa7b by Marius Stanciu to branch master.


Repository: marble


Description
-------

The feature was disabled(greyed out) and it didn't work. Now drawing the placemark keeps account of the scale member.

I have one issue though:
I didn't really know where to place a constant for a maximum icon size( limiting the user ) so I could use your opinion.


Diffs
-----

  src/lib/marble/EditPlacemarkDialog.ui 2d09c6e 
  src/lib/marble/PlacemarkLayout.cpp 6c0af30 
  src/lib/marble/VisiblePlacemark.h 805112d 
  src/lib/marble/VisiblePlacemark.cpp d57dcb0 

Diff: https://git.reviewboard.kde.org/r/122849/diff/


Testing
-------

works for me.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150323/4ed3c711/attachment.html>