[Marble-devel] Review Request 123107: Further elevation calculation improvements

[Torsten Rahn]

> On März 22, 2015, 10:33 nachm., Torsten Rahn wrote:
> > Ship It!
> 
> Oliver Haag wrote:
>     Any more I should do at this point (That I can do without a kde git account)? Don't have any experience commiting changes with git, so sorry for any stupid questions ;)

Hi Oliver. Thanks a lot for this nice and very useful patch. And sorry for having this patch lying around for so long. I just submitted it. You can test it with latest master. The only thing you can do now is test master or create another nice patch like this ;-)))


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123107/#review77932
-----------------------------------------------------------


On März 23, 2015, 7:56 nachm., Oliver Haag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123107/
> -----------------------------------------------------------
> 
> (Updated März 23, 2015, 7:56 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Further elevation calculation improvements
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/elevationprofilefloatitem/ElevationProfileFloatItem.cpp cb529271503cc6ec2312253c30f96d360d0a28ec 
> 
> Diff: https://git.reviewboard.kde.org/r/123107/diff/
> 
> 
> Testing
> -------
> 
> Using it for my own routing work (Mostly cycling tours) for half a year now, didn't do anything unexpected during this time.
> Also did some easy to verify scenarios like routing with equal start/finish point and checking if the result is 0 - which wasn't always the case with my previous commit which is why I put some more work into it.
> 
> 
> Thanks,
> 
> Oliver Haag
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150323/04063c4f/attachment.html>