[Marble-devel] Review Request 123053: Annotate plugin: polyline and groundOverlay fixes.

Constantin Mihalache mihalache.c94 at gmail.com
Sat Mar 21 12:12:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123053/
-----------------------------------------------------------

(Updated March 21, 2015, 12:12 p.m.)


Review request for Marble and Calin Cruceru.


Changes
-------

added a similar solve for polygon editing. removed the code that solved a ground overlay bug and moved it to a new review.


Repository: marble


Description (updated)
-------

Bugs:
#1 In EditPolylineDialog, modifying the width spinbox didn't update the polyline on the globe.
#2 In EditPolygonDialog, modifying the width spinbox didn't update the polyline on the globe.


Diffs (updated)
-----

  src/plugins/render/annotate/EditPolygonDialog.h 6f07648 
  src/plugins/render/annotate/EditPolygonDialog.cpp 8c8b302 
  src/plugins/render/annotate/EditPolylineDialog.h 4d383b8 
  src/plugins/render/annotate/EditPolylineDialog.cpp a99a3e9 

Diff: https://git.reviewboard.kde.org/r/123053/diff/


Testing
-------

It solved the mentioned issues.


Thanks,

Constantin Mihalache

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150321/e4c59171/attachment.html>


More information about the Marble-devel mailing list