[Marble-devel] Review Request 122977: Fixed not showing the texture, when adding a Ground Overlay from the Edit Maps panel.
Dávid Kolozsvári
freedawson at gmail.com
Sat Mar 21 11:48:59 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122977/
-----------------------------------------------------------
(Updated March 21, 2015, 11:48 a.m.)
Status
------
This change has been marked as submitted.
Review request for Marble.
Changes
-------
Submitted with commit f5b791dbea460ac6d4cd075eeb0fb4e8683889de by Torsten Rahn on behalf of Dávid Kolozsvári to branch master.
Repository: marble
Description
-------
This feature worked in the past, but a regression occured. With git-bisect I was able to find the commit, wich introduced this bug, it was the last change made to EditGroundOverlayDialog.cpp 2 months ago, commit ID: f1b4a5dff6d30ff04a8b6bd3ff4ffdb0f0d60977.
I was able to fix this, adding a few changes to the file, without the need to revert the commit wich introduced this bug, because that commit was a bugfix too.
Diffs
-----
src/plugins/render/annotate/EditGroundOverlayDialog.cpp e401d55
Diff: https://git.reviewboard.kde.org/r/122977/diff/
Testing
-------
Testing was done, and works fine for me.
Thanks,
Dávid Kolozsvári
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150321/f6d88842/attachment.html>
More information about the Marble-devel
mailing list