[Marble-devel] Review Request 123083: Fixes Marble crash when loading corrupt annotation file.

Torsten Rahn tackat at kde.org
Sat Mar 21 09:46:14 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123083/#review77866
-----------------------------------------------------------



src/plugins/render/annotate/AnnotatePlugin.cpp (line 381)
<https://git.reviewboard.kde.org/r/123083/#comment53401>

    Why do we have to specify a fixed size?


- Torsten Rahn


On März 20, 2015, 1:52 nachm., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123083/
> -----------------------------------------------------------
> 
> (Updated März 20, 2015, 1:52 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Steps to reproduce: Edit Panel> Load annotation file >load a corrupt annotation file with .kml extension
> 
> Corrupt file may mean any file that misses the KML tag ( an empty file, or some random text in it)
> Now Marble pops up an error message when loading such a file.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp fb49eac 
> 
> Diff: https://git.reviewboard.kde.org/r/123083/diff/
> 
> 
> Testing
> -------
> 
> works for me.
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150321/9612a4f8/attachment.html>


More information about the Marble-devel mailing list