[Marble-devel] Review Request 122950: Added a Loop function to the tour widget playback.

[Marius Stanciu]

> On March 20, 2015, 9:29 a.m., Calin Cruceru wrote:
> > src/lib/marble/TourWidget.cpp, line 276
> > <https://git.reviewboard.kde.org/r/122950/diff/2/?file=355004#file355004line276>
> >
> >     Again, what does m_isLooping tell you? Why isn't checking if the toggle loop action is checked enough?

well..without that variable, when stopping the tour from playing while toggleLoopAction is checked (via the stop button) the tour will keep looping, ( the loop condition is in the StopPlaying function). So shortly, a second variable(m_isLooping) is needed to be able to interrupt the looping via the stop button without unchecking the toggleloopaction.


- Marius


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122950/#review77809
-----------------------------------------------------------


On March 15, 2015, 12:37 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122950/
> -----------------------------------------------------------
> 
> (Updated March 15, 2015, 12:37 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The loop function is availible via the movie's slider context menu. It can be toggled on and off at user's choice.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.h 0e0c3f6 
>   src/lib/marble/TourWidget.cpp 852ab04 
> 
> Diff: https://git.reviewboard.kde.org/r/122950/diff/
> 
> 
> Testing
> -------
> 
> works for me
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150320/462ed099/attachment.html>