[Marble-devel] Review Request 122976: Added the possibility to delete graphic items (polygons, lines and placemarks) and and their particular node by pressing "Delete" key

Calin Cruceru crucerucalincristian at gmail.com
Fri Mar 20 07:34:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122976/#review77784
-----------------------------------------------------------


This has already been solved. What you did different is not really needed nor intuitive from the user's part. For deleting the selected nodes maybe we could add annother keyboard shortcut. :)

- Calin Cruceru


On March 16, 2015, 9:53 a.m., hardik  beladiya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122976/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 9:53 a.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Bugs: 344540
>     http://bugs.kde.org/show_bug.cgi?id=344540
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> I added the if else condition to check whether item selected is line or polygon and then cast into them andcafter that check whether node is selected or whole item is selected
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp fb49eac 
> 
> Diff: https://git.reviewboard.kde.org/r/122976/diff/
> 
> 
> Testing
> -------
> 
> I have tested and it delete particular node if we selected particular node of line or polygon and it can also delete the whole item by selecting the them and there is no crash or other problem in my patch i test each and every condition
> 
> 
> Thanks,
> 
> hardik  beladiya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150320/a95deff3/attachment.html>


More information about the Marble-devel mailing list