[Marble-devel] Review Request 122854: Marble: Fix comparison of GeoDataPolygon's

[Boris Egorov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122854/
-----------------------------------------------------------

(Updated March 10, 2015, 4:34 a.m.)


Review request for Marble.


Changes
-------

Add testing details.


Repository: marble


Description
-------

We should compare GeoDataLinearRing's of different GeoDataPolygon's, not
one with itself. Check that in TestEquality::polygonTest().

Issue detected by Cppcheck: "Same expression on both sides of '!='."


Diffs
-----

  src/lib/marble/geodata/data/GeoDataPolygon.cpp 9ae7091 
  tests/TestEquality.cpp a3f5498 

Diff: https://git.reviewboard.kde.org/r/122854/diff/


Testing (updated)
-------

Build marble, make sure TestEquality fails unless patch is applied.


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150310/e9a9d5c7/attachment.html>