[Marble-devel] Review Request 122853: Fix construction of unknown planet

[Boris Egorov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122853/
-----------------------------------------------------------

(Updated March 9, 2015, 8:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Repository: marble


Description
-------

If we pass unknown planet name to PlanetFactory, it must show warning           
and set planet name to 'Unknown'. See commit 61e92c8ff13a26565 for              
proper behavior.

Issue detected by Cppcheck: "Expression is always false because 'else           
if' condition matches previous condition at line 80."


Diffs
-----

  src/lib/marble/PlanetFactory.cpp 9c4b1d2 

Diff: https://git.reviewboard.kde.org/r/122853/diff/


Testing
-------


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150309/2ec3b0e5/attachment.html>