[Marble-devel] Review Request 122854: Marble: Fix comparison of GeoDataPolygon's

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122854/#review77229
-----------------------------------------------------------


Good catch. Can you also extend the current TestEquality::polygonTest() in tests/TestEquality.cpp such that it fails unless your patch is applied?

- Dennis Nienhüser


On March 8, 2015, 8:01 a.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122854/
> -----------------------------------------------------------
> 
> (Updated March 8, 2015, 8:01 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> We should compare GeoDataLinearRing's of different GeoDataPolygon's, not
> one with itself.
> 
> Issue detected by Cppcheck: "Same expression on both sides of '!='."
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataPolygon.cpp 9ae7091 
> 
> Diff: https://git.reviewboard.kde.org/r/122854/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150309/9bc2556d/attachment.html>