[Marble-devel] Review Request 122426: Marble: solved visual glitches on mouse events

[Calin Cruceru]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122426/#review77169
-----------------------------------------------------------


It looks good to me.

@Dennis, @Torsten what do you think?

- Calin Cruceru


On Feb. 4, 2015, 11:15 p.m., Constantin Mihalache wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122426/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 11:15 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Bug#1: When double-clicking and the mouse cursor is not above the map, zoom-in triggers and this came as very annoying while trying to pan the globe without dragging.
> 
> -coding: 
>         -addded an if statement which tests whether the mouse is/isn't above the map.
> Bug#2: While the globe is spinning (after a mouse drag), using pan with arrows causes a visual glitch: the globe jumps to a position for a fraction of a second but it continues its spin.
> 
> -coding: 
>         -added a bool function to KineticModel which retruns whether the globe is spinning or not (checking its velocity). this helped me further on.
>         -added an extra condition which ensures that panning with arrows triggers only when the globe's velocity is null.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MarbleInputHandler.cpp 0fe322c 
>   src/lib/marble/kineticmodel.h 731d124 
>   src/lib/marble/kineticmodel.cpp b246781 
> 
> Diff: https://git.reviewboard.kde.org/r/122426/diff/
> 
> 
> Testing
> -------
> 
> Built the project after applying the patch. Worked as expected. 
> 
> 
> Thanks,
> 
> Constantin Mihalache
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150307/ad279b44/attachment.html>