[Marble-devel] Review Request 122748: Marble crashes when moving the slider before creating a tour in the Tour Widget panel

[Marius Stanciu]

> On March 1, 2015, 7:09 p.m., Dennis Nienhüser wrote:
> > Looks fine and should be pushed.
> > 
> > That being said the implementation seems to work around the original crash. The method triggering the crash should be fixed additionally so that it can be called even if no tour has been set yet (and does nothing then).

okay i'll go ahead and fix the method itself too then :)


- Marius


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122748/#review76826
-----------------------------------------------------------


On Feb. 28, 2015, 9:37 a.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122748/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2015, 9:37 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Disabled the slider in the constructor, enabled it after creating a project.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.cpp 6bce39d 
> 
> Diff: https://git.reviewboard.kde.org/r/122748/diff/
> 
> 
> Testing
> -------
> 
> works on master branch @ 20 feb
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150301/a5d96254/attachment.html>