[Marble-devel] Review Request 122747: Adds highlighting to currently played items in Tour Widget.

Marius Stanciu stanciumarius94 at gmail.com
Sun Mar 1 19:25:01 UTC 2015



> On March 1, 2015, 7:19 p.m., Dennis Nienhüser wrote:
> > Nice one, this will be very helpful when creating/modifying tours also. I wonder if it would be possible to http://qt-project.org/doc/qt-4.8/qabstractitemview.html#setCurrentIndex to store the index of the item to be highlighted instead of a member variable? setCurrentIndex() can be called without modifying the selection even to keep the original selection of the user.

I will give it a try.


- Marius


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122747/#review76827
-----------------------------------------------------------


On Feb. 27, 2015, 8:14 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122747/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 8:14 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> The tour widget lacked real time highlighting to items currently played while previewing a movie.
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.h 0e0c3f6 
>   src/lib/marble/TourWidget.cpp 6bce39d 
>   src/lib/marble/SerialTrack.h 3146d7f 
>   src/lib/marble/SerialTrack.cpp 667b85f 
>   src/lib/marble/TourItemDelegate.h 25477e6 
>   src/lib/marble/TourItemDelegate.cpp 9eb0b66 
>   src/lib/marble/TourPlayback.h 4c6d64d 
>   src/lib/marble/TourPlayback.cpp 07f4cdb 
> 
> Diff: https://git.reviewboard.kde.org/r/122747/diff/
> 
> 
> Testing
> -------
> 
> works on master branch @ 20 feb.
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150301/82d4866b/attachment.html>


More information about the Marble-devel mailing list