[Marble-devel] Review Request 122728: Fixed 2 minor bugs in the Tour Widget panel

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122728/#review76828
-----------------------------------------------------------



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/122728/#comment52877>

    Please use curly brackets even for one liners, see the kdelibs coding style.
    
    if ( currentIndex.isValid() ) {
        m_tourUi.m_listView->scrollTo( currentIndex );
    }



src/lib/marble/TourWidget.cpp
<https://git.reviewboard.kde.org/r/122728/#comment52876>

    In which case is the current index not valid? If this should not happen really, I'd rather do nothing in that case.


- Dennis Nienhüser


On Feb. 26, 2015, 12:38 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122728/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 12:38 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Bug 1: When editing an already exisiting "Wait x seconds" item, the wrong icon is displayed( the sound cue one )
> 
> Bug 2: Added an autoscroll to the item list. Now when you add a new item, the list will scroll to it, making it easier to track newly added items. ( This behaviour is usefull when dealing with many items )
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/TourWidget.cpp 6bce39d 
>   src/lib/marble/WaitEditWidget.cpp 70f8acf 
> 
> Diff: https://git.reviewboard.kde.org/r/122728/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150301/fbbbce5f/attachment-0001.html>