[Marble-devel] Review Request 124188: A patch for Bug 300184 - Eartquake Plugin: Need to use config dialog to see recent earth quakes

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124188/#review81805
-----------------------------------------------------------



src/plugins/render/earthquake/EarthquakePlugin.cpp (line 167)
<https://git.reviewboard.kde.org/r/124188/#comment56135>

    can we get rid of the if clause and just call
    `m_ui->m_timeRangeNPastDaysRadioButton->setChecked( m_timeRangeNPastDays );` ?


- Dennis Nienhüser


On June 27, 2015, 10:18 p.m., Alexey Bugrov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124188/
> -----------------------------------------------------------
> 
> (Updated June 27, 2015, 10:18 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> A patch for  Bug 300184 - Eartquake Plugin: Need to use config dialog to see recent earth quakes
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/earthquake/EarthquakeConfigWidget.ui 0cc1804 
>   src/plugins/render/earthquake/EarthquakePlugin.h 1cb88b7 
>   src/plugins/render/earthquake/EarthquakePlugin.cpp 47f041c 
> 
> Diff: https://git.reviewboard.kde.org/r/124188/diff/
> 
> 
> Testing
> -------
> 
> Done some testing, seems to work ok. Passes the unit tests too.
> 
> 
> Thanks,
> 
> Alexey Bugrov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150628/b1d7ceb2/attachment.html>