[Marble-devel] Review Request 124188: A patch for Bug 300184 - Eartquake Plugin: Need to use config dialog to see recent earth quakes
Torsten Rahn
tackat at kde.org
Sat Jun 27 07:33:32 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124188/#review81802
-----------------------------------------------------------
src/plugins/render/earthquake/EarthquakePlugin.cpp (line 184)
<https://git.reviewboard.kde.org/r/124188/#comment56132>
I guess that could be written as
m_timeRangeNPastDays = m_ui->m_timeRangeNPastDaysRadioButton->isChecked()
- Torsten Rahn
On Juni 26, 2015, 5:03 nachm., Alexey Bugrov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124188/
> -----------------------------------------------------------
>
> (Updated Juni 26, 2015, 5:03 nachm.)
>
>
> Review request for Marble and Torsten Rahn.
>
>
> Repository: marble
>
>
> Description
> -------
>
> A patch for Bug 300184 - Eartquake Plugin: Need to use config dialog to see recent earth quakes
>
>
> Diffs
> -----
>
> src/plugins/render/earthquake/EarthquakeConfigWidget.ui 0cc1804
> src/plugins/render/earthquake/EarthquakePlugin.h 1cb88b7
> src/plugins/render/earthquake/EarthquakePlugin.cpp 47f041c
>
> Diff: https://git.reviewboard.kde.org/r/124188/diff/
>
>
> Testing
> -------
>
> Done some testing, seems to work ok. Passes the unit tests too.
>
>
> Thanks,
>
> Alexey Bugrov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150627/87152373/attachment.html>
More information about the Marble-devel
mailing list