[Marble-devel] Review Request 124182: Enhance GeoDataLatLonQuad

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124182/#review81756
-----------------------------------------------------------


Can you elaborate on the purpose of the patch? The description is a bit short. Thanks :)


src/lib/marble/MergedLayerDecorator.cpp (line 234)
<https://git.reviewboard.kde.org/r/124182/#comment56067>

    could also be implemented like this:
    
    bool const hasQuad = overlay->latLonQuad().isValid();
    GeoDataLatLonBox const overlayLatLonBox = hasQuad ? overlay->latLonQuad().latLonAltBox() : overlay->latLonBox();
    
    The benefit is to avoid computing overlay->latLonBox() in any case and keeping the const qualifier of overlayLatLonBox.
    
    Is it intentional that the Alt part of the box is stripped away due to the conversion?



src/lib/marble/geodata/data/GeoDataLatLonAltBox.cpp (line 119)
<https://git.reviewboard.kde.org/r/124182/#comment56064>

    this is not needed, the GeoDataLatLonAltBoxPrivate constructor does it already.



src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp (line 208)
<https://git.reviewboard.kde.org/r/124182/#comment56066>

    where is all the work done?


- Dennis Nienhüser


On June 25, 2015, 6:16 p.m., Ana Badescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124182/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 6:16 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Use latLonAltBox to retrieve information about GeoDataLatLonQuad
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/MergedLayerDecorator.cpp 47ac63e 
>   src/lib/marble/geodata/data/GeoDataLatLonAltBox.h 1d04433 
>   src/lib/marble/geodata/data/GeoDataLatLonAltBox.cpp f0bbe6b 
>   src/lib/marble/geodata/data/GeoDataLatLonQuad.h d38848a 
>   src/lib/marble/geodata/data/GeoDataLatLonQuad.cpp 6cb9748 
>   src/lib/marble/geodata/handlers/kml/KmlLatLonQuadTagHandler.cpp 57b3465 
> 
> Diff: https://git.reviewboard.kde.org/r/124182/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ana Badescu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150625/bb30d0f7/attachment-0001.html>