[Marble-devel] Review Request 124097: gsoc: Translator classes used in writing osm files

Marius Stanciu stanciumarius94 at gmail.com
Sun Jun 21 13:20:43 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated June 21, 2015, 1:20 p.m.)

Review request for Marble.

Repository: marble


These classes are used to translate the GeoDataDocuments into syntactically correct osm files.

The OsmDocumentTranslator iterates through all the features within a document and writes them in the right order.
The OsmPlacemarkTranslator gets all the data necesarry at GeoDataPlacemark level, and passes it to the static osm writer functions from the last patch.
The OsmFeatureTranslator is an abstract translator, the document and placemark ones inherit this.

Diffs (updated)

  src/plugins/runner/osm/translators/OsmDocumentTagTranslator.h PRE-CREATION 
  src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp PRE-CREATION 
  src/plugins/runner/osm/translators/OsmFeatureTagTranslator.h PRE-CREATION 
  src/plugins/runner/osm/translators/OsmFeatureTagTranslator.cpp PRE-CREATION 
  src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.h PRE-CREATION 
  src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124097/diff/


No testing was done yet as these are just static functions, will taste in later patches.
Compiles fine


Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150621/e3b97be8/attachment.html>

More information about the Marble-devel mailing list