[Marble-devel] Review Request 124099: gsoc: connecting the writers to the annotation plugin

[Dennis Nienhüser]

> On June 15, 2015, 8:23 p.m., Dennis Nienhüser wrote:
> > src/plugins/render/annotate/AnnotatePlugin.cpp, line 354
> > <https://git.reviewboard.kde.org/r/124099/diff/1/?file=379892#file379892line354>
> >
> >     why not?
> 
> Marius Stanciu wrote:
>     not sure if it's my machine's fault or not, or if it's an issue with Plasma, but the open/save file dialogs freeze unless that option is set :|
>     Could someone maybe confirm either of those?
> 
> Dennis Nienhüser wrote:
>     does the same happen with the one in marble opened from the file => open menu?
> 
> Marius Stanciu wrote:
>     weirdly, not.

Might be a plasma issue. At least here QFileDialog::open freezes Marble sometimes and sometimes not (I tried File => Open and Bookmark Manager => Import).


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124099/#review81493
-----------------------------------------------------------


On June 14, 2015, 8:46 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124099/
> -----------------------------------------------------------
> 
> (Updated June 14, 2015, 8:46 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> Choosing .osm file format when saving annotation file now correctly outputs osm files.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp 9284540 
>   src/plugins/runner/osm/CMakeLists.txt 4a341e7 
> 
> Diff: https://git.reviewboard.kde.org/r/124099/diff/
> 
> 
> Testing
> -------
> 
> Created a bunch of features in the edit mode and saved them. Reloaded the file in marble, it worked!
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150620/63cb6700/attachment.html>