[Marble-devel] Review Request 123837: gsoc: Solves coloring issue when loading OSM files

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123837/#review81402
-----------------------------------------------------------

Ship it!


Looks good to me.

- Torsten Rahn


On Mai 18, 2015, 3:19 nachm., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123837/
> -----------------------------------------------------------
> 
> (Updated Mai 18, 2015, 3:19 nachm.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> When loading OSM files, features are assigned a hardcoded style ( corresponding to a tag ). That style was overwritten in the annotate plugin's loadAnnotationFile function.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/annotate/AnnotatePlugin.cpp 41a6dd9 
> 
> Diff: https://git.reviewboard.kde.org/r/123837/diff/
> 
> 
> Testing
> -------
> 
> tested with the following file: http://textuploader.com/fwft
> -before the patch, the polygon is white (overwritten to default).
> -after the patch, the polygon is blue ( relation's water tag ).
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150612/9b406636/attachment.html>