[Marble-devel] Review Request 124519: Jump to current location button for Marble Maps

Gábor Péterffy peterffy95 at gmail.com
Fri Jul 31 23:23:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519/
-----------------------------------------------------------

(Updated Aug. 1, 2015, 1:23 a.m.)


Review request for Marble.


Changes
-------

Fixing issues and features and icons have been optimised by optipng.


Repository: marble


Description
-------

This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position.


Diffs (updated)
-----

  data/android/drawable-xxxhdpi/backdrop.png PRE-CREATION 
  data/android/drawable-xxxhdpi/gps_fixed.png PRE-CREATION 
  data/android/drawable-xxxhdpi/gps_not_fixed.png PRE-CREATION 
  data/android/drawable-xxxhdpi/marblelogo.png bf462f7608169f70cc014d8da1e0ad86e11bed15 
  src/apps/marble-maps/BoxedText.qml PRE-CREATION 
  src/apps/marble-maps/CircularButton.qml PRE-CREATION 
  src/apps/marble-maps/IndicatorCircularButton.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml 2cc996aef7b89f888f822ef4ff3bf5460c729991 
  src/apps/marble-maps/MarbleMaps.qrc d027af982f31144107baedf77fe07f7239ef53ed 
  src/lib/marble/declarative/MarbleQuickItem.h cca329761f23cd72315df2d359166a2cbfa8056c 
  src/lib/marble/declarative/MarbleQuickItem.cpp e7dbbe7de31858286f6d0e38f5721f7f8ae45e79 
  src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp 35884a7c844b590ecf44f3346f0d41b4c46b0f81 

Diff: https://git.reviewboard.kde.org/r/124519/diff/


Testing
-------

It seems my distance or angle functions are not working well, the almost always provide false data after some panning (my position is sometimes start to change when I am panning on the map, strange thing: the position marker also starts to go to an other place like it is fixed to the screen, but the map moves under it sometimes when I am penning and it is not jumping back to its place.)


File Attachments (updated)
----------------

gps_not_fixed.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png
gps_fixed.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png
marblelogo.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ebaa4d45-b337-4e42-8a23-a73e2d88ddca__marblelogo.png
backdrop.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dacf5958-7270-40c4-9031-243350a80de8__backdrop.png


Thanks,

Gábor Péterffy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150731/7b83695e/attachment-0001.html>


More information about the Marble-devel mailing list