[Marble-devel] Review Request 124541: [MarbleMaps] Added search completion

[Mihail Ivchenko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124541/
-----------------------------------------------------------

(Updated Aug. 1, 2015, 1:16 a.m.)


Review request for Marble and Gábor Péterffy.


Changes
-------

Also switched to Holo.Light theme.


Repository: marble


Description
-------

Added search completion for Marble Maps.


Diffs (updated)
-----

  src/lib/marble/declarative/SearchBackend.cpp 5c80cc3 
  data/android/drawable-xxxhdpi/search.png 599a3c7ccdcedb11835378562f7f34c2a4c39669 
  src/apps/marble-maps/Completion.qml PRE-CREATION 
  src/apps/marble-maps/MainScreen.qml 2cc996a 
  src/apps/marble-maps/MarbleMaps.qrc d027af9 
  src/apps/marble-maps/Search.qml 896f266 
  src/apps/marble-maps/SearchField.qml 5830098 
  src/apps/marble-maps/SearchResults.qml a910038 
  src/apps/marble-maps/package/AndroidManifest.xml 4409ec5 
  src/lib/marble/declarative/SearchBackend.h b041de3 

Diff: https://git.reviewboard.kde.org/r/124541/diff/


Testing
-------

Works on Nexus 5 and Nexus 9 (both are Android 5.1.1)

I'm not sure about color for background so I created a screenshot which shows all available colors from SystemPalette with default Holo Dark theme on stock Android 5.1.1.


File Attachments (updated)
----------------

Screenshot_2015-08-01-01-06-06.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/a115b5d5-7f57-4089-a896-d8fbf2ed2320__Screenshot_2015-08-01-01-06-06.png
Screenshot_2015-08-01-01-06-12.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/7df5b460-e705-4da3-a846-a9d308f37daf__Screenshot_2015-08-01-01-06-12.png
Screenshot_2015-08-01-01-06-16.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/386444f1-8d4e-43de-96fd-9810f91e5a14__Screenshot_2015-08-01-01-06-16.png
Screenshot_2015-08-01-01-06-22.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/490fe2b2-8cf3-4456-82c1-08b9a81dcc89__Screenshot_2015-08-01-01-06-22.png
Screenshot_2015-08-01-01-06-26.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/6d497bac-01ea-424d-a636-da1b2a5d0311__Screenshot_2015-08-01-01-06-26.png


Thanks,

Mihail Ivchenko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150731/68f3d75b/attachment.html>