[Marble-devel] Review Request 124553: gsoc: Changes key type for the member hash within OsmPlacemarkData

[Marius Stanciu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124553/
-----------------------------------------------------------

(Updated July 31, 2015, 5:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Marble.


Changes
-------

Submitted with commit 3a83ed99b6aa852a770c97cad6c363d05f49994e by Marius Stanciu to branch master.


Repository: marble


Description
-------

It seems storing data with pointer keys within a QHash wasn't a good idea:
A polygon's inner boundaries are stored within a QVector, which reallocates it's objects sometimes, thus pointers to inner boundaries are not constant.
Changed the key to int with the following meaning:

-1 ===> outer boundary of a polygon
0,1,2,3...etc =====> inner boundaries of a polygon in the order provided by polygon->innerBoundaries() ( the QVector order )

This wasn't a problem until I started modiying inner boundaries in the editor.


Diffs
-----

  src/lib/marble/osm/OsmPlacemarkData.h 58f7e69 
  src/lib/marble/osm/OsmPlacemarkData.cpp c78888b 
  src/plugins/runner/osm/OsmObjectManager.cpp 85f78d2 
  src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp 2e1c9b7 
  src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp cac7852 
  src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp 8f79a17 

Diff: https://git.reviewboard.kde.org/r/124553/diff/


Testing
-------

Usual tests ( added polygons, imported, exported, reimported ), stuff works as expected.


Thanks,

Marius Stanciu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150731/563a1744/attachment.html>