[Marble-devel] Review Request 124521: gsoc: Preparation for adding the KML OsmPlacemarkData writers/handlers

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124521/#review83165
-----------------------------------------------------------

Ship it!


Looks good.


src/lib/marble/osm/OsmPlacemarkData.h (line 140)
<https://git.reviewboard.kde.org/r/124521/#comment57429>

    Both places should be fine.


- Dennis Nienhüser


On July 29, 2015, 12:16 p.m., Marius Stanciu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124521/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 12:16 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> - Added the "mx" namespace, needed to separate the upcoming custom XML schema
> - Added an easy osmPlacemarkData setter for GeoDataPlacemark, in order to avoid working with GeoExtendedData and hash entries all the time
> - Made the OsmPlacemarkData osmAttributeData() const an OsmPlacemarkData constructor, because it will be needed from the KmlParser sources as well
> ( not available from OsmParser.h )
> 
> 
> Diffs
> -----
> 
>   src/lib/marble/geodata/data/GeoDataPlacemark.h f1eadd8 
>   src/lib/marble/geodata/data/GeoDataPlacemark.cpp de36b5e 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h f2c062c 
>   src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp ea53d43 
>   src/lib/marble/geodata/parser/GeoDataParser.cpp 588b086 
>   src/lib/marble/osm/OsmPlacemarkData.h 58f7e69 
>   src/lib/marble/osm/OsmPlacemarkData.cpp c78888b 
>   src/plugins/runner/kml/KmlParser.cpp 4a9fa6a 
>   src/plugins/runner/osm/OsmParser.h 141f4f6 
>   src/plugins/runner/osm/OsmParser.cpp c9b63b0 
>   src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp 1f6160f 
>   src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp 892adb5 
>   src/plugins/runner/osm/handlers/OsmTagTagHandler.h 9bf9e0c 
>   src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp d3fd2f2 
>   src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp cb84d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/124521/diff/
> 
> 
> Testing
> -------
> 
> compiles fine, no real changes to test.
> 
> 
> Thanks,
> 
> Marius Stanciu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150730/e607f6fa/attachment-0001.html>