[Marble-devel] Review Request 124519: Jump to current location button for Marble Maps

[Gábor Péterffy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519/
-----------------------------------------------------------

(Updated júl. 30, 2015, 2:13 de)


Review request for Marble.


Changes
-------

Fixing issues and also introducing some gui element.


Repository: marble


Description (updated)
-------

This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position.


Diffs (updated)
-----

  src/lib/marble/MarbleQuickItem.cpp 883a873fb325b2b713d0387e17d21417b27f3bee 
  src/lib/marble/MarbleQuickItem.h cca329761f23cd72315df2d359166a2cbfa8056c 
  src/apps/marble-maps/MarbleMaps.qrc d027af982f31144107baedf77fe07f7239ef53ed 
  src/apps/marble-maps/MainScreen.qml 60a4a54cfe5f80e5eb7386ead3e8f6e393014152 
  src/apps/marble-maps/IndicatorCircularButton.qml PRE-CREATION 
  src/apps/marble-maps/CircularButton.qml PRE-CREATION 
  src/apps/marble-maps/BoxedText.qml PRE-CREATION 
  data/android/drawable-xxxhdpi/gps_not_fixed.png PRE-CREATION 
  data/android/drawable-xxxhdpi/gps_fixed.png PRE-CREATION 
  data/android/drawable-xxxhdpi/backdrop.png PRE-CREATION 
  src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp 77c70c725ceeca69e71e758bc26ba4dd26b80854 

Diff: https://git.reviewboard.kde.org/r/124519/diff/


Testing (updated)
-------

It seems my distance or angle functions are not working well, the almost always provide false data after some panning (my position is sometimes start to change when I am panning on the map, strange thing: the position marker also starts to go to an other place like it is fixed to the screen, but the map moves under it sometimes when I am penning and it is not jumping back to its place.)


File Attachments (updated)
----------------

backdrop.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/71c68ee3-562a-4686-8a41-889997356456__backdrop.png
gps_not_fixed.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png
gps_fixed.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png


Thanks,

Gábor Péterffy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20150730/0f065181/attachment.html>